Fix issue #12928 (Report documentation looks a bit odd when there is no docs for a report) #22739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… there is no docs for a report)
michalkleiner
requested changes
Nov 10, 2024
|
I corrected what you asked for! Thanks for the help @michalkleiner! Could you review this PR again, please? |
michalkleiner
requested changes
Nov 10, 2024
michalkleiner
requested changes
Nov 11, 2024
|
Fixes #12928 |
|
Lint errors corrected! :) |
|
Hi @michalkleiner ! Anything else to correct? |
|
Hey @michalkleiner , I'm sorry for bothering you, but are there any more changes to be made? If there are, I'll work on them right away, otherwise, could you merge this? Thank you so more for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change addresses the issue where the report documentation appears odd or empty when no documentation is available for a report. Specifically, it ensures that a default message ("No documentation available for this report.") is displayed when reportDocumentation is empty or missing. This improves the user experience by providing clear feedback instead of showing a blank or incomplete UI.
Review